Repository navigation
Conversation
Path previews can attempt to read from non-regular files, such as character devices, which can have unintended side effects. This can happen by just typing a device's absolute path without even requesting a preview. For example, if you type /dev/uart.debug-console into a text file on macOS, the debug console device will be opened, and a non-blocking read will begin that never terminates. This results in neovim freezing when the user tries to quit, as the character device never completes reading. To avoid opening character devices or other non-regular files which may have side effects, we first check that the file's type is actually a regular file before trying to read from it.
Author
|
Actually, I thought about this some more and we should call fstat before trying to open the file, not after. Will fix and submit new PR |
Author
|
See #2644 for updated PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path previews can attempt to read from non-regular files, such as character devices, which can have unintended side effects. This can happen by just typing a device's absolute path without even requesting a preview.
For example, if you type /dev/uart.debug-console into a text file on macOS, the debug console device will be opened, and a non-blocking read will begin that never terminates. This results in neovim freezing when the user tries to quit, as the character device never completes reading.
To avoid opening character devices or other non-regular files which may have side effects, we first check that the file's type is actually a regular file before trying to read from it.