Repository navigation
Conversation
Collaborator
|
Hey, great job! Been super busy lately, fixing some IRL stuff and might take a few more weeks... I'll be glad to polish this up on my next spare time but feel free to merge if you think this can land sooner. Don't want to hold you back! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the biggest breaking change from V1 -> V2, replacing our custom sources system with
blink.lib.lspfor in-process LSPs which work with any completion engine (including native!). Additionally, this makes use of the built-invim.lspand runtimelsp/*detection. This PR also switches from a custom task implementation tovim.async.blink.compatfor v1 sources -> v2 LSPI'm going on a vacation for a week, so I'll be late to respond, but feedback is appreciated! @soifou feel free to commit on this branch directly if you'd like to make any changes.
Configuration
Rather than the user defining
sources = { default = { ... }, providers = {} }, everything gets defined throughvim.lsp.*andcmp.lsp.*(similar API tovim.lsp+ per-buffer).Since pure declarative configuration is so common, we also provide a more limited
lsp = {}option insetup()for users who don't want to use the programmatic interface.Cmdline
Rather than scattering special cases for cmdline/terminal modes across the codebase, the LSPs attach to a buffer with filetype
blink-cmdlinewhich mirrors the actual cmdline's content and performs two-way sync between them. This was surprisingly simple to implement and avoids any special configuration onvim.lsp(simply register your LSP for theblink-cmdlinefiletype). This approach also supports out-of-process LSPs such asvimls, although I haven't explicitly tested this.Snippets
The user's snippet engine is now automatically detected from loaded modules. The built-in snippets engine was temporarily dropped, but I'm planning to either add it back to this repo or create a separate
blink.snippetsproject, but I'm unsure which to do atm.