Skip to content

fix: handle undecodable MultiSend data in event processing #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
falvaradorodriguez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle undecodable MultiSend data in event processing #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions app/services/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import json
import logging

from eth_abi.exceptions import DecodingError
from eth_typing import ChecksumAddress, HexStr
from hexbytes import HexBytes
from safe_eth.eth.constants import NULL_ADDRESS
Expand All @@ -28,10 +29,14 @@ def get_contracts_from_data(self, data: HexStr | None) -> set[ChecksumAddress]:
"""
if not data:
return set()
return {
multisend_tx.to
for multisend_tx in MultiSend.from_transaction_data(HexBytes(data))
}
try:
return {
multisend_tx.to
for multisend_tx in MultiSend.from_transaction_data(HexBytes(data))
}
except (ValueError, DecodingError, ArithmeticError) as exc:
logger.warning("Cannot decode MultiSend from data %s: %s", data, exc)
return set()

async def process_event(self, message: str) -> None:
"""
Expand Down
Loading