Add support for proxy contract decoding#287
Open
moisses89 wants to merge 20 commits into
Open
Conversation
moisses89
commented
May 28, 2026
| # Set expiration just if is not configured | ||
| if await redis.ttl(hash_key) == -1: | ||
| await redis.expire(hash_key, expire) | ||
| await redis.expire(hash_key, expire, nx=True) |
Member
Author
There was a problem hiding this comment.
Using NX redis option so at this way we don't need the ttl query and we avoid a minor issue with a possible race condition.
https://redis.io/docs/latest/commands/expire/
Uxio0
requested changes
Jun 8, 2026
This comment has been minimized.
This comment has been minimized.
| if address is not None: | ||
| async with transactional_session_context(): | ||
| if chain_id is not None and await self.get_contract_abi( | ||
| if chain_id is not None and await self._has_contract_abi( |
Contributor
There was a problem hiding this comment.
Is this method proxy-aware? I mean, it only checks _has_contract_abi against the proxy’s address, not that of the implementation. A proxy without its own ABI but with an implementation ABI is decoded correctly, but is reported as PARTIAL_MATCH/ONLY_FUNCTION_MATCH instead of FULL_MATCH. The decoding was proxy-aware, but the accuracy was not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes PLA-1524 #242
When a contract has an implementation address, it indicates that the contract is a proxy. In such cases, the implementation contract should be used for contract decoding instead of the proxy address.