fix(s3): use virtual-hosted style for Aliyun OSS#151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #150.
Background
Issue #150 reports that
rc ls aliyun/fenxi-data/fails against Alibaba Cloud OSS withSecondLevelDomainForbidden.Alibaba Cloud documents this error as a bucket-scoped OSS request using an endpoint shape that does not include the bucket in the host. Bucket operations need virtual-hosted-style access such as
bucket.oss-region.aliyuncs.com.Root Cause
bucket_lookup = autowas treated the same aspath, so rc sent Aliyun OSS object-list requests as path-style requests to the regional OSS endpoint. OSS rejects that shape for bucket operations.Solution
--bucket-lookup pathand--bucket-lookup dnsbehavior unchanged.automode, detect Aliyun OSS service endpoints likeoss-cn-hangzhou.aliyuncs.comand use virtual-hosted-style addressing.Validation
cargo test -p rc-s3 client::tests:: --libcargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspaceI could not run against the reporter private Aliyun bucket, but the failing error code, official OSS endpoint rule, and local address-selection tests cover the root cause.