test(s3): cover select serialization shapes#147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
No direct issue. This is focused test-gap coverage for the recently merged S3 Select support.
Background and impact
The SQL command maps CLI select options into AWS S3 Select serialization structures before sending SelectObjectContent. The previous tests covered error classification and the Parquet compression guard, but did not assert the successful CSV, JSON-lines, compression, or output serialization shapes.
Root cause
The new builder paths in rc-s3 were only indirectly exercised, leaving regressions in request serialization choices hard to catch with the existing unit tests.
Solution
Add focused rc-s3 unit tests for CSV input defaults with BZIP2 compression, JSON input using LINES mode with GZIP compression, and output serialization selection between CSV and JSON.
Test status
cargo test -p rc-s3 select::tests --libcargo fmt --all --checkmake pre-commit