Conversation
rustbot
added
A-attributes
mejrs
marked this pull request as ready for review
October 4, 2026 12:45
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
S-waiting-on-review
JonathanBrouwer
approved these changes
Oct 4, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
❌ Commit dcce9b0 has been unapproved due to PR CI failure. Reapprove it with |
mejrs
force-pushed
the
attr_parsing_track_diagnostics
branch
from
October 4, 2026 15:04
dcce9b0 to
90c7f95
Compare
Collaborator
|
cc @rust-lang/clippy |
Member
Author
|
@bors r=jonathanbrouwer |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…athanbrouwer fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing r? @GuillaumeGomez or perhaps @JonathanBrouwer
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…uwer Rollup of 6 pull requests Successful merges: - #161491 (Rip out old solver coherence) - #163223 (regression test for async handler normalization ICE) - #163653 (callconv: mips64: Match GCC for alignment of 16-byte scalars) - #163742 (Add the `movdir64b` and `movdiri` x86 target features) - #163752 (Revert "implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]") - #163755 (fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing)
Member
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #163763 (comment) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#163763), which was unapproved. |
Member
Author
|
oops i forgor the normalization |
mejrs
force-pushed
the
attr_parsing_track_diagnostics
branch
from
October 4, 2026 21:25
90c7f95 to
6d99887
Compare
Member
Author
|
@bors r=jonathanbrouwer |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @GuillaumeGomez or perhaps @JonathanBrouwer