Repository navigation
Revert "implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]" - #163752
Merged
rust-bors[bot] merged 1 commit intoOct 4, 2026
Conversation
…[T; N], &[T; N] and &mut [T; N]" Revert "fix stability attributes for VecDeque PartialEq impls" This reverts commit 9942d36. Revert "update VecDeque PartialEq stability metadata" This reverts commit 3d3f2f8. Revert "update assert-ne-no-invalid-help-issue-146204.stderr for VecDeque PartialEq output" This reverts commit 8cdd010. Revert "resolve too_generic_eval_ice stderr conflict" This reverts commit b50d79a. Revert "alloc: make VecDeque partial equality symmetric with vec/slice/array" This reverts commit 835975a.
rustbot
added
the
S-waiting-on-review
rustbot
added
T-compiler
Collaborator
|
|
Member
|
I wonder whether we can maybe do FCP here – we have a lot of time until the next beta branch, this is probably uncontroversial, and it seems like a bit of a hassle to revert this just to land it again. I'll propose a disposition-merge FCP for merging the original change. If anyone disagrees with that way going about it, simply cancel FCP and r+ this PR. @rust-rfcbot merge libs |
Collaborator
|
@joboet has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/libs-ping: FCP proposed for libs, please feel free to register concerns. |
rust-rfcbot
added
proposed-final-comment-period
Contributor
Author
|
Sure, but now we have FCPs in both places. .-. |
Member
Contributor
|
📋 This PR cannot be approved because it currently has the following label: |
joboet
removed
the
proposed-final-comment-period
This comment was marked as resolved.
This comment was marked as resolved.
joboet
added
the
proposed-final-comment-period
Contributor
Author
|
(This is a known problem; someone on @rust-lang/libs-fcp has to cancel.) |
Member
|
@rfcbot cancel |
Collaborator
|
@ChrisDenton proposal cancelled. |
rust-rfcbot
removed
proposed-final-comment-period
Contributor
Author
|
Gonna just @bors r+ rollup and we can do FCP in the other thread. |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 4, 2026
…leq, r=clarfonthey Revert "implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]" This should go through FCP. This is a revert so we can do FCP on the actual PR. r? joboet
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…uwer Rollup of 6 pull requests Successful merges: - #161491 (Rip out old solver coherence) - #163223 (regression test for async handler normalization ICE) - #163653 (callconv: mips64: Match GCC for alignment of 16-byte scalars) - #163742 (Add the `movdir64b` and `movdiri` x86 target features) - #163752 (Revert "implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]") - #163755 (fix -Z track-diagnostics for errors and lints emitted from rustc_attr_parsing)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
…uwer Rollup of 9 pull requests Successful merges: - #161491 (Rip out old solver coherence) - #163533 (Run cg_gcc tests with the correct compiler) - #163223 (regression test for async handler normalization ICE) - #163367 (simplify rustc_log a bit) - #163622 (x86: c-variadic functions don't use registers with `-Zregparm`) - #163653 (callconv: mips64: Match GCC for alignment of 16-byte scalars) - #163665 (Parser: Refactor & better document `should_continue_as_assoc_expr` & `can_continue_expr_unambiguously`) - #163742 (Add the `movdir64b` and `movdiri` x86 target features) - #163752 (Revert "implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]")
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 4, 2026
Rollup merge of #163752 - clarfonthey:revert-vecdeque-partialeq, r=clarfonthey Revert "implement PartialEq<VecDeque<U>> for Vec<T>, &[T], &mut [T], [T; N], &[T; N] and &mut [T; N]" This should go through FCP. This is a revert so we can do FCP on the actual PR. r? joboet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should go through FCP. This is a revert so we can do FCP on the actual PR.
r? joboet