lower spans of error const args and test binder bounds - #163750
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
Member
|
Not familiar with this code. r? compiler |
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 63c07bd with merge 67e8503... Workflow: https://github.com/rust-lang/rust/actions/runs/37280098399 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 5, 2026
lower spans of error const args and test binder bounds fixes #163592 lower spans when constructing hir nodes for error const args and test binder bound type constraints, these paths were using raw ast spans instead of routing them through `lower_span` (reproduce with `rust.debug-assertions = true` and `-Cincremental`; the tests listed in the issue now pass.) r? @bjorn3 cc @matthiaskrgr
Member
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #156674. |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 5, 2026
Rollup merge of #163750 - paradoxicalguy:ice-span-wo-parent, r=oli-obk lower spans of error const args and test binder bounds fixes #163592 lower spans when constructing hir nodes for error const args and test binder bound type constraints, these paths were using raw ast spans instead of routing them through `lower_span` (reproduce with `rust.debug-assertions = true` and `-Cincremental`; the tests listed in the issue now pass.) r? @bjorn3 cc @matthiaskrgr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #163592
lower spans when constructing hir nodes for error const args and test binder bound type constraints, these paths were using raw ast spans instead of routing them through
lower_span(reproduce with
rust.debug-assertions = trueand-Cincremental; the tests listed in the issue now pass.)r? @bjorn3
cc @matthiaskrgr