Bump rustls and related crates to latest versions#556
Bump rustls and related crates to latest versions#556tcharding merged 1 commit intorust-bitcoin:masterfrom
rustls and related crates to latest versions#556Conversation
30b0c81 to
c39a671
Compare
|
You could add a cargo audit CI job here as well. |
|
You need to alllow the duplicate deps on bitreq's Cargo.toml to fix linting |
Eh, well, yes, see #557.
I'm aware, still trying to keep the duplicates minimal though, will update in abit. |
|
@tcharding if we could get new |
Since there have recently been some advisories, we bump `rustls` and related crates such as `rustls-webpki` to latest versions.
c39a671 to
9ddc66f
Compare
|
Should be fixed now. |
You mean |
| rustls-native-certs = { version = "0.6.1", default-features = false, optional = true } | ||
| webpki-roots = { version = "0.25.2", default-features = false, optional = true } | ||
| rustls-webpki = { version = "0.101.0", default-features = false, optional = true } | ||
| rustls = { version = "0.23.38", default-features = false, features = ["ring", "std", "tls12"], optional = true } |
There was a problem hiding this comment.
Its weird to see std here (but I see its there in the serde_json dep too). I am surprised this doesn't break the no-std build. Both of these commands are clean, no clue why?
cargo test --no-default-features --features=rustlscargo test --no-default-features --features=json-using-serde
There was a problem hiding this comment.
Its weird to see
stdhere (but I see its there in theserde_jsondep too). I am surprised this doesn't break the no-std build. Both of these commands are clean, no clue why?
cargo test --no-default-features --features=rustlscargo test --no-default-features --features=json-using-serde
Note that before this bump std was implicit for rustls. Only rustls 0.23 introduced no_std support.. That said, given that v0.23 was releases Feb 2024, I'm not sure why we started off with v0.21in bitreq to begin with. However, only now we could entertain the possibility to make bitreq with rustls really no_std compatible.
Exactly. Yeah, jsonrpc will need it too since it's on the dep tree. BDK uses |
Fixes #553.
Alternative to #536, which also bumps
rustls-webpkiand other related crates.Since there have recently been some advisories, we bump
rustlsand related crates such asrustls-webpkito latest versions.