Skip to content

Unify usage of GHA workflows from rusefi/rusefi repository #10

Open

Description

@kifir23917

Currently Create Board Firmware GHA workflow reuses workflow from ext/rusefi submodule, while Update rusEFI Reference GHA workflow reuses workflow directly from rusefi/rusefi repository.
This potentially can cause inconsistency in versions of GHA workflows in use (for example we can unintentially use workflows from different branches).
Do we need to consider unification for ways of reusing GHA workflows from rusefi/rusefi repository?

Activity

  1. rusefillc commented on Jun 11, 2024

    @rusefillc
    Contributor

    Definitely but zero priority until we figure out which approach is better when and why.

  2. chuckwagoncomputing commented on Jun 11, 2024

    @chuckwagoncomputing
    Member

    Create Board Firmware uses the custom action from the submodule because of this:
    rusefi/rusefi#6114

    The value of unification seems small to me.
    Using a workflow/custom action from the submodule comes with downsides, listed in rusefi/rusefi#6162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions