Repository navigation
chore(deps): floor certifi at 2026.10.19 (GHSA-6q48-6c7w-9gw2) - #368
Merged
Merged
Conversation
The vllm/vllm-openai base image ships certifi, and pip/uv leave an installed package alone unless a requirement forces the upgrade, so base images built before 2026-10-19 keep a bundle that trusts the emSign ECC Root CA - G3 (eight compromised intermediates, no CRL/OCSP check). Pinning certifi>=2026.10.19 forces the upgrade at image build. Closes #367
colin99d
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
certifi>=2026.10.19tobuilder/requirements.txt, per #367.Why
The image builds
FROM vllm/vllm-openai, which already ships certifi.pip install -r builder/requirements.txtleaves an installed packagealone if it already satisfies the requirements, so base images built
before 2026-10-19 keep a CA bundle that trusts the **emSign ECC Root CA
(GHSA-6q48-6c7w-9gw2,
certifi does not check revocation). Pinning the floor forces pip/uv to
upgrade the pre-installed copy at image build time.
Verification (inside the rebuilt image)
Note: grepping for just "emSign" still matches on fixed versions —
2026.10.19+ keeps the unaffected emSign Root CA - G1.
Follow-up (out of scope here)
Rebuild every published tag so shipped images pick up the fixed bundle.
Closes #367