fix(mail): auto-dismiss toggling flags notification#1784
Open
Keegil wants to merge 1 commit intorunbox:masterfrom
Open
fix(mail): auto-dismiss toggling flags notification#1784Keegil wants to merge 1 commit intorunbox:masterfrom
Keegil wants to merge 1 commit intorunbox:masterfrom
Conversation
Ensure the snackbar shown when toggling flags from the message list closes automatically after a few seconds instead of persisting. Add a focused spec for AppComponent.setFlaggedStatus(). runbox#1732
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1732
Problem
The "Toggling flags..." snackbar shown from the message list had no duration, so it stayed visible until the user dismissed it manually or reloaded.
Fix
Add a 3-second duration to the snackbar opened by \ and add a focused spec covering the snackbar configuration.
Testing
WARNING: Reverting to committed package-lock.json. If that means your changes are lost you should rebuild it.
All dependency versions ok. Will build production bundle.
Updating changelog
changes.ts updated
Updating appData
Initial Chunk Files | Names | Raw Size | Estimated Transfer Size
main.5939afddff8d889d.js | main | 3.45 MB | 581.94 kB
scripts.b9d51b4e1ab69b6a.js | scripts | 486.03 kB | 147.26 kB
styles.555fc4b7cb74ba62.css | styles | 140.38 kB | 16.15 kB
polyfills.f74b78f4f6795abc.js | polyfills | 70.29 kB | 22.33 kB
runtime.c39162d4ab90c2f1.js | runtime | 3.93 kB | 1.82 kB
| Initial Total | 4.14 MB | 769.49 kB
Lazy Chunk Files | Names | Raw Size | Estimated Transfer Size
src_app_calendar-app_calendar-app_module_ts.3be23388b3f37a27.js | calendar-app-calendar-app-module | 316.02 kB | 60.54 kB
src_app_xapian_index_worker_ts.33f3a01e2f7d1db7.js | - | 266.28 kB | 56.56 kB
src_app_changelog_changelog_module_ts.2fae88cf5e397388.js | changelog-changelog-module | 147.67 kB | 41.48 kB
src_app_contacts-app_contacts-app_module_ts.f3c53b0d9b584af0.js | contacts-app-contacts-app-module | 72.21 kB | 14.63 kB
src_app_dev_dev_module_ts.34ea55c51bf35b1b.js | dev-dev-module | 24.91 kB | 5.91 kB
src_app_dkim_dkim_module_ts.b0b9aa978f723513.js | dkim-dkim-module | 13.86 kB | 3.85 kB
common.f5176967c7c93e69.js | common | 10.47 kB | 3.43 kB
src_app_onscreen_onscreen_module_ts.2b403b614c70bb13.js | onscreen-onscreen-module | 727 bytes | 432 bytes
Build at: 2026-03-25T21:28:01.709Z - Hash: 9c47c42aaf23351c - Time: 23966ms
Run the following command to commit it:
git commit src/app/changelog/changes.ts -em "docs(changelog): Update changelog"
Notes
25 03 2026 22:28:07.696:INFO [karma-server]: Karma v6.4.4 server started at http://localhost:9876/
25 03 2026 22:28:07.696:INFO [launcher]: Launching browsers FirefoxHeadless with concurrency unlimited
25 03 2026 22:28:07.697:INFO [launcher]: Starting browser FirefoxHeadless
25 03 2026 22:28:07.698:ERROR [launcher]: No binary for FirefoxHeadless browser on your platform.
Please, set "FIREFOX_BIN" env variable.
25 03 2026 22:28:07.699:ERROR [karma-server]: UncaughtException: TypeError: Cannot read properties of undefined (reading 'stderr')
at FirefoxBrowser._start (/Users/kjetil/Code/runbox7/node_modules/karma-firefox-launcher/index.js:273:19)
at Object. (/Users/kjetil/Code/runbox7/node_modules/karma/lib/launchers/process.js:19:10)
at Object.emit (node:events:520:22)
at Object.emit (node:domain:489:12)
at BaseLauncher.start (/Users/kjetil/Code/runbox7/node_modules/karma/lib/launchers/base.js:52:10)
at Object.j (/Users/kjetil/Code/runbox7/node_modules/karma/lib/launcher.js:108:17)
at setTimeout.bind.j (/Users/kjetil/Code/runbox7/node_modules/qjobs/qjobs.js:143:18)
at listOnTimeout (node:internal/timers:605:17)
at process.processTimers (node:internal/timers:541:7)
25 03 2026 22:28:07.699:ERROR [karma-server]: TypeError: Cannot read properties of undefined (reading 'stderr')
at FirefoxBrowser._start (/Users/kjetil/Code/runbox7/node_modules/karma-firefox-launcher/index.js:273:19)
at Object. (/Users/kjetil/Code/runbox7/node_modules/karma/lib/launchers/process.js:19:10)
at Object.emit (node:events:520:22)
at Object.emit (node:domain:489:12)
at BaseLauncher.start (/Users/kjetil/Code/runbox7/node_modules/karma/lib/launchers/base.js:52:10)
at Object.j (/Users/kjetil/Code/runbox7/node_modules/karma/lib/launcher.js:108:17)
at setTimeout.bind.j (/Users/kjetil/Code/runbox7/node_modules/qjobs/qjobs.js:143:18)
at listOnTimeout (node:internal/timers:605:17)
at process.processTimers (node:internal/timers:541:7) could not run in this environment because Firefox is not installed