fix(0286): read the post-0304 amm summary in the re-ingest script - #350
Merged
Merged
Conversation
The AMM step parsed 'events with no apply order:', which task 0304 removed, so the first Soroban-era month would crash after events-backfill had written. Read 'negative apply order:' after the dry-run pass too, and check the --amm mode before the snapshot and DROP. Default to --amm ssh: events-backfill on develop has no --transport.
karczuRF
added a commit
that referenced
this pull request
Sep 24, 2026
Records PR #350, the git pull after stage A, the --ssh target, the host events-backfill build, --discover-pools and the stage B command.
A missing or non-executable events-backfill binary raised OSError out of require_transport_flag, which neither the preflight gates nor main() catch: the operator got a traceback instead of the failed-gates list. Raise Stop instead, so preflight and each month's gates step report it.
The mock's 400 ms delay against a 350 ms bound left under 300 ms of slack, and the clock also covered building the SDK client. A loaded CI runner took 587 ms and failed a deadline that did cut the call off. Build the router before timing, and set the delay to 3 s against a 2 s bound: only a response that did not wait for the mock can pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
events with no apply order:, a line task 0304 removed fromevents-backfill, so the first Soroban-era month (202402) would crash in Python after the AMM candles were written. It now readsnegative apply order:andswaps dropped (unresolved):, after the--dry-runpass as well, and stops before the write if either line is missing.--amm sshrecords dropped swaps like--amm mtlsdid. Both modes add a note for events with a negative apply order.--ammmode is checked inpreflightand in each month'sgatesstep, before the snapshot and the DROP.--amm sshwithout--sshstops there.--amm ssh, becauseevents-backfillon develop has no--transport. Thedefaultpassword is asked for only when a Soroban-era month is still to do.Stage A (running with
--amm stopto 202401) is not affected. The Comet gate was already added under 0300.