Repository navigation
Remove leftover build files; keep the version in one place - #335
Merged
Merged
Conversation
MANIFEST, Assembly (Detroit's config), .index, Indexfile and lib/core/facets.yml belonged to older Rubyworks tooling (mast, index, Detroit). The gemspec builds its own file list and metadata, so nothing read them, and they had drifted: MANIFEST was missing files and .index still said version 3.1.1. The Rakefile only used .index for the docs version; it now uses Facets::VERSION. The `prepare` task, which just regenerated MANIFEST and .index with mast and index, is gone, so `rake package` builds the gem without needing either tool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2Njj4j1r9twkVcXsMySLW
The version was kept twice, in facets.gemspec and in lib/core/facets/version.rb. The gemspec now requires version.rb and uses Facets::VERSION, so a release changes one line. The Rakefile already reads it there too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2Njj4j1r9twkVcXsMySLW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files belonged to older Rubyworks tooling (
mast,index, Detroit). Nothing reads them anymore, and they had drifted out of date:MANIFESTmastDir['lib/**/*.rb', …]). It was missing the demos and many newer files.Assemblydetroitis commented out in the Gemfile..index/Indexfileindex.indexstill said version 3.1.1 (the gem is 3.2.2).lib/core/facets.yml.rbfiles).One source for the version (
38f19f7)The version was kept twice, in
facets.gemspecand inlib/core/facets/version.rb. The gemspec now requiresversion.rband usesFacets::VERSION, so a release changes one line.The rest of the metadata
.indexwas meant to expose to code is available from RubyGems when Facets is installed as a gem, for exampleGem.loaded_specs['facets'].summary.Rakefile
.indexonly to get the version for the docs output path, so the docs task was labeling output 3.1.1. It now usesFacets::VERSION.preparetask only regeneratedMANIFESTand.indexwithmastandindex. It's removed, sorake packagebuilds the gem without either tool.Testing
Gem::Specification.load('facets.gemspec')reports version 3.2.2, andrake packagebuildsfacets-3.2.2.gem.rake test: 1,263 tests pass (4 pending).rake qed: 157 demos pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01E2Njj4j1r9twkVcXsMySLW