Handle platform alias error row extensions#9656
Draft
lukewilliamboswell wants to merge 1 commit into
Draft
Conversation
ebac927 to
85d71ce
Compare
85d71ce to
3e09b4a
Compare
3e09b4a to
98df859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9655.
Summary
Str.inspectand exits with a generic non-zero code...type-declaration diagnostic to point users at the named extension-parameter form.Testing
zig build run-test-zig-module-compile -- --test-filter "issue 9655"zig build run-test-zig-module-can -- --test-filter "open ext"zig build run-test-cli -- --suite subcommands --filter "fx-open platform alias"zig build run-test-cli -- --suite platforms --filter "fx-open"zig build run-check-test-wiringzig build run-check-fx-platform-test-coverage --summary all --color offzig build run-check-zig-formatzig build run-check-snapshotsgit diff --check./zig-out/bin/roc check test/fx-open/open_error_alias.roc./zig-out/bin/roc --opt=interpreter --no-cache test/fx-open/open_error_alias.rocNote: local
zig build miniciis blocked by unrelatedrun-test-dylib/run-test-archiveDCE canary failures (ROC_DCE_CANARY_BLOB_7f3a9c), which also fail when rerun directly.