Repository navigation
fix: make weather fetcher injectable for stable unit tests - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing CI job was caused by the weather handler performing a real external HTTP call during a test when the cache was empty.
This made the test depend on upstream network state and cache initialization, which produced flaky failures like “Expected request to be OK.”
This fix introduces an injectable WeatherFetcher so production still hits wttr.in, while tests can provide a stubbed response.
It keeps the cache behavior intact and makes the unit test deterministic.
Summary of the fix:
Add an injectable weather fetcher abstraction in controller/weather.go
Use the fetcher inside CurrentWeather
Keep cache hit/miss behavior unchanged
Make tests deterministic by injecting a mock response instead of hitting the network
This should resolve the failing job shown in:
https://github.com/robertoduessmann/weather-api/actions/runs/37654817287/job/112907127860