Bump the go-dependencies group across 3 directories with 1 update - #1372
Merged
Merged
Conversation
Bumps the go-dependencies group with 1 update in the / directory: [modernc.org/sqlite](https://gitlab.com/cznic/sqlite). Bumps the go-dependencies group with 1 update in the /cmd/river directory: [modernc.org/sqlite](https://gitlab.com/cznic/sqlite). Bumps the go-dependencies group with 1 update in the /riverdriver/riverdrivertest directory: [modernc.org/sqlite](https://gitlab.com/cznic/sqlite). Updates `modernc.org/sqlite` from 1.57.0 to 1.58.0 - [Changelog](https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/cznic/sqlite/compare/v1.57.0...v1.58.0) Updates `modernc.org/sqlite` from 1.57.0 to 1.58.0 - [Changelog](https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/cznic/sqlite/compare/v1.57.0...v1.58.0) Updates `modernc.org/sqlite` from 1.57.0 to 1.58.0 - [Changelog](https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/cznic/sqlite/compare/v1.57.0...v1.58.0) --- updated-dependencies: - dependency-name: modernc.org/sqlite dependency-version: 1.58.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-dependencies - dependency-name: modernc.org/sqlite dependency-version: 1.58.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-dependencies - dependency-name: modernc.org/sqlite dependency-version: 1.58.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
bgentry
approved these changes
Sep 8, 2026
bgentry
left a comment
Contributor
There was a problem hiding this comment.
🤖 Codex review: Approved after dependency security and compatibility review.
Upgrade
modernc.org/sqlite:v1.57.0→v1.58.0in the CLI and shared driver tests.- Runtime indirect updates:
modernc.org/libcv1.74.4→v1.75.6, andmodernc.org/memoryv1.11.0→v1.12.1. - Reviewed head:
a8b3dd43695e595b89c4fb55755ccaaad5d77ab7; base:48c0036dcb12b1e2bb65c355593388bb7ff9926e.
Security review
- A delegated, read-only supply-chain review compared the actual old/new Go module artifacts for SQLite, libc, memory, and the sum-only compiler dependencies
cc/v4,ccgo/v4, andgc/v3. All 12 artifacts' module and go.mod hashes match the public Go checksum database, with unchanged canonical GitLab sources and tagged origins. The new SQLite artifact ish1:38u40/bwkfM7f0Myhosl+SEMltSDxnGdQf8o6Kjmys0=at upstream commit722282f38b49191a4e24569eeac960bc033bd8f0. - Inspected the Go wrapper, platform-specific and normalized generated SQLite diffs, libc syscall changes, allocator changes, generation hooks, and added sensitive operations. The notable new behavior is opt-in, process-wide Linux OFD locking; it remains off by default. No unexpected credential access, exfiltration endpoint, install-time execution, source replacement, or same-version checksum rewrite was identified.
- The River
v0.44.1→v0.47.0sum churn catches checksums up with versions already required by the base manifests. No Go/toolchain directives, workspace configuration, replacements, River source, vendoring, or generated River files change. - Checked the Go vulnerability database, OSV Go records, SQLite CVEs, and SQLite 3.53.4 release information. No blocking advisory was identified for the updated module versions. This is not classified as a confirmed new security fix: comparison of the journal-recovery functions confirms the prior version already carries the rollback fix.
Compatibility verification
- Local environment: Go
1.27.0, macOS arm64, isolated PostgreSQL18.4, golangci-lint2.13.1, sqlc1.31.0. make tidyandgo mod verify— passed, with no tracked changes.make verifyandCHECK=true make update-mod-go— passed. The first generator check found only the local sqlc1.31.1version-header mismatch; rerunning with CI's exact1.31.0release passed.make test,make lint,make test/race, andmake bench ITERATIONS=1— passed across the workspace, with no tracked changes.go build -o <temporary binary> ./cmd/riverand CLI SQLite migration up/list/down, validation, SQL export, and expected validation failure after down — passed against a temporary database.- Required GitHub CI checks passed, including the Linux Go/PostgreSQL race-test matrix, Linux/Windows CLI checks, lint, benchmark, and generated-code checks. CodeQL is neutral for this bot PR; no successful CodeQL analysis is claimed.
Residual risk
- The large transpiled SQLite engine was inspected using source diffs, platform normalization, and sensitive-change analysis; it was not independently rebuilt from upstream C.
- Linux OFD opt-in behavior was inspected in source and upstream tests but could not be executed locally because this host is macOS and its Docker daemon is unavailable. Existing Linux CI exercises the default locking mode.
- Allocator retention and libc sleep timing changes may affect workloads beyond the tested scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the go-dependencies group with 1 update in the / directory: modernc.org/sqlite.
Bumps the go-dependencies group with 1 update in the /cmd/river directory: modernc.org/sqlite.
Bumps the go-dependencies group with 1 update in the /riverdriver/riverdrivertest directory: modernc.org/sqlite.
Updates
modernc.org/sqlitefrom 1.57.0 to 1.58.0Changelog
Sourced from modernc.org/sqlite's changelog.
... (truncated)
Commits
722282fCHANGELOG.md: document the OFD locking opt-in and the SQLite 3.53.4 upgrade5dcac5fsqlite: add the opt-in OFDLocking switch to Linux OFD locks51d2677Merge branch 'ofd-lock-test'3f99e26update dependencies, make vendor9159fa5test: add Linux OFD lock regression tests2acd716test: add Linux OFD lock persistence test across os.Closebd9dcb6add Readme Headline...93f0742add Readme HeadlineUpdates
modernc.org/sqlitefrom 1.57.0 to 1.58.0Changelog
Sourced from modernc.org/sqlite's changelog.