Revert "workflows: rework triggering behaviour (#364)" - #391
Merged
Conversation
This reverts commit 371ab1d.
Collaborator
Author
|
@luhenry please review ASAP, so we can get this in and fix my triggering mistake :) I've intentionally cancelled all of the workflows because we don't want to run them, just put the |
luhenry
added a commit
that referenced
this pull request
Aug 26, 2026
The previous commit dropped it to follow "workflows: rework triggering behaviour" (#364), which has since been reverted by #391 — every workflow on main declares both triggers again, and a workflow that has never run cannot be reached by workflow_dispatch or by a Trigger: line at all. Also aligns the header with the sibling workflows: the YAML document marker and the upstream-workflow reference this one is derived from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 371ab1d.
The attempt to switch to only using Trigger directives is going to break several things without more rework. Go back to the old way for now.