Skip to content

pr-trigger.yml: post link to triggered workflows - #388

Closed
threexc wants to merge 3 commits into
mainfrom
tgamblin/pr-trigger-links
Closed

pr-trigger.yml: post link to triggered workflows#388
threexc wants to merge 3 commits into
mainfrom
tgamblin/pr-trigger-links

Conversation

@threexc

@threexc threexc commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

We use a Trigger: <package>:<version> pattern in PRs to tell our workflows which versions to build for a given change, but this doesn't automatically show the actual workflows which have been triggered, and it's confusing regarding whether the default version should have a Trigger directive or not. We also don't necessarily want changes to workflows submitted with a PR to automatically trigger those workflows, since they can run for a long time and many changes may be simple maintenance cleanups or improvements.

Now, all PRs require the Trigger directive even for the default PR, and versions other than what we need should still trigger and appear in the PR UI.

Trigger: pytokens:0.4.1
Trigger: numpy:2.5.0

@github-actions

Copy link
Copy Markdown
Contributor

Triggered workflows for this PR:

@threexc
threexc requested review from justeph and luhenry August 25, 2026 18:07
@threexc

threexc commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

@luhenry this is a follow-up to my trigger rework - it posts a link to the triggered action. I thought the Trigger directive was correctly putting the running workflows into the workflow box in the interface, but I guess not. We may want to revert the merged changed so that we can get better feedback for workflows in the UI, but that's also going to be a pain if we have to make any changes to workflow files where we don't want to actually build them. What do you think?

I'll see if I can make it cleaner.

@threexc
threexc marked this pull request as draft August 25, 2026 19:12
threexc and others added 3 commits August 25, 2026 15:26
A per-package pull_request: paths trigger means any PR touching several
workflow files fires that many separate (mostly irrelevant) runs, flooding
the Actions list. workflow_dispatch is now the only way any of these run;
pr-trigger.yml's Checks-API relay gives the same visible, per-directive
status without the trigger sprawl.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Trigger: directives dispatch via workflow_dispatch, which has no PR check
of its own. Post one GitHub Check Run per directive instead of a relay
job or a PR comment: a properly named, real check (build-<pkg>.yml @
<version>) whose "Details" link goes straight to the dispatched run, with
real pending/success/failure/cancelled status mirrored via `gh run
watch`.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
@threexc
threexc force-pushed the tgamblin/pr-trigger-links branch from 13c06a0 to dd780d5 Compare August 25, 2026 19:28
@threexc

threexc commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

I think that this is much better. If you click through the links in the web UI, you can see all of the builds running for each package and version: https://github.com/riseproject-dev/python-wheels/runs/97938652031

@threexc

threexc commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

Dropping this until I can figure out the right logic for all trigger cases.

@threexc threexc closed this Aug 25, 2026
@threexc
threexc deleted the tgamblin/pr-trigger-links branch August 25, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant