Conversation
google/brotli publishes per-interpreter compiled wheels for every other Linux arch but none for riscv64. The extension vendors brotli's own C sources, so a plain build-from-checkout cibuildwheel run suffices. Tests mirror upstream's `setup.py test` (removed from modern setuptools) via `unittest discover -s python`; python/tests, python/bro.py and tests/testdata are staged with test-sources so the suite's relative lookups resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a riscv64 wheel build for brotli 1.2.0
(the Python bindings in google/brotli).
Upstream publishes per-interpreter compiled wheels (
cpXY-cpXY) for x86_64,aarch64 and ppc64le, glibc and musl — but nothing for riscv64.
Shape
Plain build-from-checkout with cibuildwheel.
setup.pycompilespython/_brotli.cagainst brotli's own vendored C tree (c/common,c/dec,c/enc), so no external native dependency and nobefore-buildare needed —CIBW_MANYLINUX_RISCV64_IMAGEis the only build-side override.Matrix is per-interpreter (
cp312/cp313/cp314/cp314t): the extension isnot abi3, matching the
cpXY-cpXYwheels upstream ships.Testing
Upstream's CI runs
python setup.py test, which discoverspython/**/*_test.py.The
testcommand is gone from modern setuptools, so the workflow runs theequivalent
python -m unittest discover -s python -p '*_test.py'.The suite resolves its fixtures relative to the source tree (
tests/testdata,and
python/bro.pywhichbro_test.pyspawns as a subprocess), so those arestaged with
CIBW_TEST_SOURCESalongsidepython/tests. Because cibuildwheelruns the tests from an otherwise-empty directory,
import brotli/import _brotliresolve to the installed wheel rather than the checkout.Verified locally on aarch64 before pushing: 595 tests pass, the wheel contains
_brotli.cpython-3XX-*.so,brotli.__file__and_brotli.__file__both pointinto site-packages, and the wheel carries upstream's MIT
LICENSE(all Csources are brotli's own, so there is no third-party licence to add).