Skip to content

Implement Rate limiting #63

Open
Open

Description

@rikai

Currently there is no concept of rate limiting in the bot, this needs to be addressed alongside #40.

Activity

  1. added this to the Next Release milestone on Aug 8, 2016
  2. rikai commented on Aug 20, 2016

    @rikai
    OwnerAuthor

    Turns out cinch has rate limiting already and this too

    We just need to add the config option and decide what a good default value is.

  3. s0ph0s-dog commented on May 27, 2017

    @s0ph0s-dog

    Based on the channel modes on #JupiterBroadcasting, I would suggest the following settings:

    • messages_per_second: 1 (JBot can't send more than half of the messages in any given 5-second window)
    • server_queue_size: 5 (The hard limit is 10, so half that seems reasonable)
  4. rikai commented on May 27, 2017

    @rikai
    OwnerAuthor

    Mmm, keep in mind that JBot also talks in PMs, so this has to account for throughput for that as well, not ONLY the channel.

  5. s0ph0s-dog commented on May 27, 2017

    @s0ph0s-dog

    That's a good point.
    However, there haven't been any other suggestions… perhaps we could implement these numbers, then tweak them if they seem too conservative?

  6. rikai commented on May 27, 2017

    @rikai
    OwnerAuthor

    Sounds fine to me. 👍

  7. s0ph0s-dog commented on May 28, 2017

    @s0ph0s-dog

    Should I submit a PR that adds these settings to cinchize.yml.example?

  8. rikai commented on May 28, 2017

    @rikai
    OwnerAuthor

    Yes please

  9. rikai commented on Jun 1, 2017

    @rikai
    OwnerAuthor

    leaving this open until i can 100% confirm it works. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions