Repository navigation
chore: turn on all the lints we meant to turn on - #63
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
Split the extractor pattern table and per-line processing out of long functions, avoid holding `gix::Repository` across an `.await`, replace index arithmetic, and drop the removed `no_mangle_generic_items` lint. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
Replace `unreachable!` by dispatching on a `CheckKind` enum, move each subcommand into its own function, and drop the unfulfilled `#[expect(clippy::enum_variant_names)]`. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
Hoist `use` items to the top of the file and make the parenthesized-TODO test table-driven. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
BatmanAoD
marked this pull request as ready for review
November 14, 2026 00:06
BatmanAoD
commented
Nov 17, 2026
BatmanAoD
force-pushed
the
enable-lints
branch
from
November 17, 2026 22:24
101b093 to
77f2e2d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lints were copied from another project originally, and were defined at the workspace level but not inherited by the package. This is a warning that currently can't be turned into a hard error.