Skip to content

chore: turn on all the lints we meant to turn on - #63

Merged
BatmanAoD merged 9 commits into
mainfrom
enable-lints
Nov 17, 2026
Merged

BatmanAoD merged 9 commits into
mainfrom
enable-lints

Conversation

@BatmanAoD

@BatmanAoD BatmanAoD commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Lints were copied from another project originally, and were defined at the workspace level but not inherited by the package. This is a warning that currently can't be turned into a hard error.

BatmanAoD and others added 5 commits November 13, 2026 12:16
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
Split the extractor pattern table and per-line processing out of long
functions, avoid holding `gix::Repository` across an `.await`, replace
index arithmetic, and drop the removed `no_mangle_generic_items` lint.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
@BatmanAoD BatmanAoD changed the title turn on all the lints we meant to turn on chore: turn on all the lints we meant to turn on Nov 13, 2026
BatmanAoD and others added 3 commits November 13, 2026 16:55
Replace `unreachable!` by dispatching on a `CheckKind` enum,
move each subcommand into its own function,
and drop the unfulfilled `#[expect(clippy::enum_variant_names)]`.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
Hoist `use` items to the top of the file
and make the parenthesized-TODO test table-driven.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K3mkz7wKFhKEVpWsYnW2g9
@BatmanAoD
BatmanAoD marked this pull request as ready for review November 14, 2026 00:06
Comment thread src/checker.rs Resolved
@BatmanAoD
BatmanAoD merged commit c52d702 into main Nov 17, 2026
7 checks passed
@BatmanAoD
BatmanAoD deleted the enable-lints branch November 17, 2026 22:28
@github-actions github-actions Bot mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant