Skip to content

Fix work time check issue when startHour and endHour are the same - #120

Open
alphapku wants to merge 2 commits into
rickar:masterfrom
alphapku:hotfix/work-time-fix
Open

Fix work time check issue when startHour and endHour are the same#120
alphapku wants to merge 2 commits into
rickar:masterfrom
alphapku:hotfix/work-time-fix

Conversation

@alphapku

@alphapku alphapku commented Nov 1, 2023

Copy link
Copy Markdown

Why

  1. When the startHour and endHour the same, IsWorkTime returns incorrectly

What

  1. Use time.Duration to check if the working time (time of date) is in the range or not.

@rickar

rickar commented Nov 4, 2023

Copy link
Copy Markdown
Owner

Can you please reapply your changes on top of PR #119 that was just merged?

@alphapku

Copy link
Copy Markdown
Author

Can you please reapply your changes on top of PR #119 that was just merged?

Sure, done, please check it out. Thanks for your work, again!

@rickar

rickar commented Jan 12, 2024

Copy link
Copy Markdown
Owner

Can you fix the failing tests please?

@SagarJadhav30 SagarJadhav30 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants