Skip to content

EPMRPP-115237 || Move encryption logic to service-api - #54

Merged
Evelina02 merged 5 commits into
developfrom
EPMRPP-115237-encrypt-sensitive
Jun 18, 2026
Merged

EPMRPP-115237 || Move encryption logic to service-api#54
Evelina02 merged 5 commits into
developfrom
EPMRPP-115237-encrypt-sensitive

Conversation

@Evelina02

@Evelina02 Evelina02 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor
    • Simplified GitLab integration credential handling by streamlining API token processing during integration creation and updates.
    • Updated service API dependency version.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@grabsefx, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 35 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0d31732e-737f-442d-9c16-310f18102ca2

📥 Commits

Reviewing files that changed from the base of the PR and between 111eb06 and dde4dd0.

📒 Files selected for processing (17)
  • build.gradle
  • gradle.properties
  • src/main/java/com/epam/reportportal/extension/gitlab/GitlabExtension.java
  • src/main/java/com/epam/reportportal/extension/gitlab/client/GitlabClient.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/DescriptionBuilderService.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/GetIssueCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/GetIssueFieldsCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/GetIssueTypesCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/GetIssuesCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/PostTicketCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/RetrieveCreationParamsCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/RetrieveUpdateParamsCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/SearchEpicsCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/SearchLabelsCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/SearchMilestonesCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/SearchUsersCommand.java
  • src/main/java/com/epam/reportportal/extension/gitlab/command/TestConnectionCommand.java

Walkthrough

RetrieveCreationParamsCommand and RetrieveUpdateParamsCommand are updated to store the GitLab API_TOKEN as plaintext instead of encrypting it via BasicTextEncryptor. The encryptor field, constructor, and import are removed from both commands, and GitlabExtension no longer passes textEncryptor when instantiating them. The service-api snapshot dependency hash is also bumped in build.gradle.

Changes

API Token Encryption Removal and Dependency Bump

Layer / File(s) Summary
Remove token encryption from Retrieve*ParamsCommands and wiring
src/main/java/com/epam/reportportal/extension/gitlab/command/RetrieveCreationParamsCommand.java, src/main/java/com/epam/reportportal/extension/gitlab/command/RetrieveUpdateParamsCommand.java, src/main/java/com/epam/reportportal/extension/gitlab/GitlabExtension.java
RetrieveCreationParamsCommand removes the BasicTextEncryptor import, field, and parameterized constructor; API_TOKEN is now stored raw. RetrieveUpdateParamsCommand removes the textEncryptor.encrypt(token) call. GitlabExtension#getCommonCommands instantiates both commands with no constructor arguments.
Bump service-api snapshot hash
build.gradle
Updates the implementation and annotationProcessor entries for com.github.reportportal:service-api from revision e81b4f6 to 6599f2c.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hop hop, no more encrypt!
The token flows plain and unclipped,
BasicTextEncryptor, goodbye,
No cipher needed — let it fly!
The rabbit cheers, the build hash flipped! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly relates to the main change: removing encryption logic from the command classes and moving it to the service-api dependency (updated in build.gradle).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch EPMRPP-115237-encrypt-sensitive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Evelina02 and others added 3 commits June 17, 2026 16:25
…7-encrypt-sensitive

# Conflicts:
#	build.gradle
#	src/main/java/com/epam/reportportal/extension/gitlab/GitlabExtension.java
#	src/main/java/com/epam/reportportal/extension/gitlab/command/RetrieveCreationParamsCommand.java
#	src/main/java/com/epam/reportportal/extension/gitlab/command/RetrieveUpdateParamsCommand.java
@Evelina02
Evelina02 merged commit 179c300 into develop Jun 18, 2026
3 checks passed
@Evelina02
Evelina02 deleted the EPMRPP-115237-encrypt-sensitive branch June 18, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants