feat: add dummy implementation for Hurd - #54
Open
pinotree wants to merge 1 commit into
Open
Conversation
At the moment, the Hurd does not have a non-portable way to get the MAC address of network interfaces. Considering that the API of this crate already considers the cases "no interfaces with MAC addresses" and "no matching interface", then: - add a dummy implementation that provides no network interfaces and return no MAC address - use this implementation on the Hurd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, the Hurd does not have a non-portable way to get the MAC address of network interfaces.
Considering that the API of this crate already considers the cases "no interfaces with MAC addresses" and "no matching interface", then:
This crate has a growing amount of other crates that rely on it, either as mandatory or optional requirement. Since the API allows for this, with such implementation it is possible to avoid changes in the dependency tree of other crates.