Skip to content

Add biosolids share limit to industry#2335

Open
clarabachorz wants to merge 3 commits intoremindmodel:developfrom
clarabachorz:develop-limitBioSolidsIndst
Open

Add biosolids share limit to industry#2335
clarabachorz wants to merge 3 commits intoremindmodel:developfrom
clarabachorz:develop-limitBioSolidsIndst

Conversation

@clarabachorz
Copy link
Copy Markdown
Contributor

@clarabachorz clarabachorz commented Apr 28, 2026

Purpose of this PR

The industry module does not currently set a limit on the amount of biosolids that can be used. However, in industry sectors that use solids (mostly cement and steel), biomass is only partly substitutable due to technical limitations. In the steel sector, this is around 30% based on current literature. We implement this in q37_limitBioSolidsIndst using v37_shSolidsIndst.

Type of change

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ☑️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information

  • Comparison of results:
    FE in industry:
image

Co2 prices:
image

@clarabachorz clarabachorz requested a review from JakobBD April 29, 2026 15:25
@clarabachorz clarabachorz marked this pull request as ready for review April 29, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant