ci: pin calibreapp/image-actions to a full commit SHA#7481
Open
kobihikri wants to merge 1 commit into
Open
Conversation
calibreapp-image-actions.yml hands this third-party action a bot PAT (secrets.PANKOD_BOT_TOKEN); the dispatch variant hands it GITHUB_TOKEN. Both reference the mutable @main tag. Pin to the current main commit SHA so a moved tag can't run unreviewed code with those tokens. Behaviour unchanged; per GitHub's pin-to-SHA guidance. Signed-off-by: Kobi Hikri <kobi.hikri@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
calibreapp/image-actions@main→e9858fb…incalibreapp-image-actions.ymlandcalibreapp-image-actions-dispatch.yml(tag kept in a comment).Why
calibreapp-image-actions.ymlpassesgithubToken: ${{ secrets.PANKOD_BOT_TOKEN }}(a bot PAT withrepo write scope) directly to this third-party action, referenced by the moving
@mainref. If thataction's
mainwere moved (compromise or an accidental change), the new code would run in refine's CIwith the bot PAT — the class of issue behind the 2025
tj-actions/changed-filesincident. Pinning toa SHA removes that. (The dispatch variant passes the scoped
GITHUB_TOKEN; pinned for consistency.)Scope / safety
Behaviour unchanged (SHA = current tip of main). Signed-off. Per GitHub's pin-to-SHA guidance.
AI-assisted; I verified the workflows, the token exposure, and the pinned SHA myself.