Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis PR modifies three documentation-related files to prepare Iceberg catalog migration content. The Antora playbook configuration is updated to include a feature branch (DOC-2128) instead of main for the local content source. The navigation file reorders Iceberg entries to list the query-iceberg-topics page before migrate-to-iceberg-topics. A new AsciiDoc page scaffold is created for Iceberg catalog migration with metadata attributes and content includes. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@local-antora-playbook.yml`:
- Line 18: The branches list in local-antora-playbook.yml currently includes the
temporary feature branch name
(DOC-2128-document-procedure-to-migrate-from-the-object-stor) instead of the
stable branch; update the branches array under the branches key to replace that
feature branch with main (keeping the other entries like v/*, shared,
site-search intact) so local pulls after merge will point to the stable main
branch and not a soon-to-be-deleted feature branch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c087369a-365d-49b1-9cf9-8a90a123640f
📒 Files selected for processing (3)
local-antora-playbook.ymlmodules/ROOT/nav.adocmodules/manage/pages/iceberg/migrate-iceberg-catalog.adoc
| branches: HEAD | ||
| - url: https://github.com/redpanda-data/documentation | ||
| branches: [main, v/*, shared, site-search] | ||
| branches: [DOC-2128-document-procedure-to-migrate-from-the-object-stor, v/*, shared, site-search] |
There was a problem hiding this comment.
Revert the temporary feature branch to main before merging.
Replacing main with DOC-2128-document-procedure-to-migrate-from-the-object-stor in the local playbook means anyone who pulls main after this PR merges will be missing all stable content from redpanda-data/documentation (main) and will get a broken or empty local build once that feature branch is eventually deleted.
🔧 Proposed fix
- branches: [DOC-2128-document-procedure-to-migrate-from-the-object-stor, v/*, shared, site-search]
+ branches: [main, v/*, shared, site-search]🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@local-antora-playbook.yml` at line 18, The branches list in
local-antora-playbook.yml currently includes the temporary feature branch name
(DOC-2128-document-procedure-to-migrate-from-the-object-stor) instead of the
stable branch; update the branches array under the branches key to replace that
feature branch with main (keeping the other entries like v/*, shared,
site-search intact) so local pulls after merge will point to the stable main
branch and not a soon-to-be-deleted feature branch.
Description
Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:
Page previews
Checks