Enhance Validations and add Code-Highlighter#3265
Conversation
Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
+ Coverage 53.57% 53.87% +0.29%
==========================================
Files 2407 2381 -26
Lines 86535 86214 -321
Branches 23960 23929 -31
==========================================
+ Hits 46361 46445 +84
+ Misses 38593 38192 -401
+ Partials 1581 1577 -4
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
| } | ||
| } | ||
|
|
||
| function pickNumericBound( |
There was a problem hiding this comment.
This seems to be copy&paste with the catalogItemFormTypes.ts. Can it be shared? Like moving this to a file with utility functions.
There was a problem hiding this comment.
Correct - forget to enhance this.
| anchor="right" | ||
| open={open} | ||
| onClose={submitting ? undefined : onClose} | ||
| onClose={submitting || Boolean(error) ? undefined : onClose} |
There was a problem hiding this comment.
Isn't the user trapped in when an error is rendered? The user would need to use the X button first, then close. Sounds weird but it might be he intention
There was a problem hiding this comment.
We have two scenarios:
- User clicks on "X" -> Drawer closes always unless they're submitting an api request
- User has an error and he click anywhere in the screen -> Drawer keeps open
And this is totally fine - we need to keep drawer open so user can fix the issues, unless he decided to go away and close it -> by pressing X icon.
|
2 participants
Uh oh!
There was an error while loading. Please reload this page.