Skip to content

fix: backport GitHub login fix to release-2.1 (2.1.21) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
subhashkhileri merged 2 commits into from
Oct 6, 2026
Merged

fix: backport GitHub login fix to release-2.1 (2.1.21) #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6dacce
fix: github login locator error (#174)
jrichter1 Oct 2, 2026
4ef2c80
chore: bump release-2.1 to 2.1.21
subhashkhileri Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@

All notable changes to this project will be documented in this file.

## [2.1.20] - Current
## [2.1.21] - Current

### Fixed

- **LoginHelper#logintoGithub**: remove the wait for the outdated Home heading locator and wait for the redirect to the GitHub homepage.

## [2.1.20]

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@red-hat-developer-hub/e2e-test-utils",
"version": "2.1.20",
"version": "2.1.21",
"description": "Test utilities for RHDH E2E tests",
"license": "Apache-2.0",
"repository": {
Expand Down
4 changes: 1 addition & 3 deletions src/playwright/helpers/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,7 @@ export class LoginHelper {
await this.page.fill("#app_totp", this.getGitHub2FAOTP(userid));
}

await this.page
.getByRole("heading", { name: "Home" })
.waitFor({ timeout: 30_000 });
await this.page.waitForURL("https://github.com/", { timeout: 20000 });
}

async logintoKeycloak(popup: Page, userid: string, password: string) {
Expand Down
Loading