[olivergondza]

What does this PR do?

• 1-131_validate_rolebinding_no_tracking_annotation_propagation_test.go exists in parallel
• 1-133_validate_namespacemanagement_does_not_block_dex_token_renewal_test.go adapted to gitops-operator

PR acceptance criteria:

• [no] Documentation was updated and verified using make serve-docs
• [no] Unit tests were updated
• E2E tests were updated

What type of PR is this?

/kind enhancement

Special notes to the reviewer:

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: redhat-developer/gitops-operator
• Branch: master
• File: .coderabbit.yaml
• Commit: 1b4dd31
• Layers: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Enterprise
• Run ID: cfd57266-35a8-464f-8191-212b2255a59e

Commits

Reviewing files that changed from the base of the PR and between 1b4dd31 and c3ee71a.

Files selected for processing: 2

• argocd-operator/tests/ginkgo/sequential/1-131_validate_rolebinding_no_tracking_annotation_propagation_test.go
• test/openshift/e2e/ginkgo/sequential/1-133_validate_namespacemanagement_does_not_block_dex_token_renewal_test.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

Files with no reviewable changes: 1

• argocd-operator/tests/ginkgo/sequential/1-131_validate_rolebinding_no_tracking_annotation_propagation_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• Tests
  • Removed a test that checked whether tracking and installation-ID annotations were propagated to generated RoleBindings.
  • Updated the Dex token renewal test to detect local runs and configure the operator through its subscription or deployment during cluster runs.
  • These changes adjust the automated checks for RoleBinding annotations and namespace management behavior.

The PR removes a sequential test for RoleBinding annotation propagation. It also updates the Dex token renewal test to use e2e fixtures and a revised operator setup.

Changes: RoleBinding annotation test removal

Layer / File(s)	Summary
Remove RoleBinding annotation propagation test argocd-operator/tests/ginkgo/sequential/1-131_validate_rolebinding_no_tracking_annotation_propagation_test.go	The test that checked annotations on generated RoleBindings was removed.

Dex token renewal test setup

Layer / File(s)	Summary
Update local-run detection and operator setup test/openshift/e2e/ginkgo/sequential/1-133_validate_namespacemanagement_does_not_block_dex_token_renewal_test.go	The test now imports fixtures from the e2e Ginkgo tree, uses fixture.EnvLocalRun() for local-run detection, and configures the operator through SetEnvInOperatorSubscriptionOrDeployment. It looks up the renamed deployment in openshift-gitops-operator.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: aali309

Merge Risk: Low · up to c3ee7

The change appears mergeable, but it removes a check that would catch tracking annotations propagating to generated RoleBindings. Restore that coverage as follow-up.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the consolidation of sequential E2E tests 1-131 and 1-133 from argocd-operator.
Description check		The description accurately covers the removed duplicate test, the adapted Dex token renewal test, and the E2E test scope.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jannfis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olivergondza]

/test v4.19-ci-index-gitops-operator-bundle