Repository navigation
fix: nullable brokerage fields and mixed-account balances - #1
Merged
Merged
Conversation
- Mark Holding/Trade fields the API returns as nullable (name, prices, fees, dates) nullable in the client types. - Stop 'redbark holdings' crashing on a null holding name. - Render null money values as a dash instead of a blank cell. - 'redbark balances' with no ids now requests only banking accounts, so it no longer fails outright for users who also have a brokerage or documents connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found these two while testing the CLI against real accounts.
redbark holdingswas crashing on any holding with no name (options, unmatched symbols). The API returns those fields as nullable but the client types didn't, so the render blew up. Fixed the types and the render.redbark balanceswith no args failed completely for anyone who also has a brokerage or documents connection. It was sending every account id to /v1/balances, and the API rejects the whole batch if any account isn't a bank account. Now it only asks for banking accounts.Also made null money values show a dash instead of a blank cell.
Verified against the live API. typecheck, tests and build all pass.