Repository navigation
Skip first-class callable in ResponseStatusCodeRector - #1103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9954
ResponseStatusCodeRectorcrashed when it visited a first-class callable whose method name starts withassert, e.g.$validator->assert(...)(common with validation libraries like PSL).processAssertMethodCall()calledgetArgs()on a first-class callable, which trips the php-parser assertion:A first-class callable has no arguments to inspect, so this adds an early guard in
processMethodCall()to skip it. New skip fixture reproduces the crash without the guard (confirmed failing before the fix).