[Symfony61] Do not add #[AsCommand] without a name in CommandConfigureToAttributeRector

rules-tests/Symfony61/Rector/Class_/CommandConfigureToAttributeRector/Fixture/description_with_name_on_existing_attribute.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Symfony\Tests\Symfony61\Rector\Class_\CommandConfigureToAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+
+#[AsCommand(name: 'app:some')]
+final class DescriptionWithNameOnExistingAttributeCommand extends Command
+{
+    protected function configure(): void
+    {
+        $this->setDescription('Some description');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Symfony61\Rector\Class_\CommandConfigureToAttributeRector\Fixture;
+
+use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Command\Command;
+
+#[AsCommand(name: 'app:some', description: 'Some description')]
+final class DescriptionWithNameOnExistingAttributeCommand extends Command
+{
+}
+
+?>

rules-tests/Symfony61/Rector/Class_/CommandConfigureToAttributeRector/Fixture/skip_name_passed_to_parent_constructor.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Symfony\Tests\Symfony61\Rector\Class_\CommandConfigureToAttributeRector\Fixture;
+
+use Symfony\Component\Console\Command\Command;
+
+final class SkipNamePassedToParentConstructorCommand extends Command
+{
+    public function __construct(?string $name = 'app:some')
+    {
+        parent::__construct($name);
+    }
+
+    protected function configure(): void
+    {
+        $this->setDescription('Some description');
+    }
+}

rules-tests/Symfony61/Rector/Class_/CommandConfigureToAttributeRector/Fixture/skip_non_constant_name.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Symfony\Tests\Symfony61\Rector\Class_\CommandConfigureToAttributeRector\Fixture;
+
+use Symfony\Component\Console\Command\Command;
+
+final class SkipNonConstantNameCommand extends Command
+{
+    public function __construct(private readonly string $commandName)
+    {
+        parent::__construct();
+    }
+
+    protected function configure(): void
+    {
+        $this->setName($this->commandName);
+        $this->setDescription('Some description');
+    }
+}

rules/Symfony61/Rector/Class_/CommandConfigureToAttributeRector.php

@@ -161,6 +161,17 @@ function (Arg $arg): string {
             },
             $attributeArgs
         );
+
+        // #[AsCommand] requires a name: when there is something to move into the attribute but the name is neither
+        // on it already nor set by a constant setName() here (e.g. it is passed to the parent constructor),
+        // converting would produce an invalid attribute
+        if (! in_array('name', $existingAttributeNames, true)
+            && ! $this->hasPermittedMethodCall($configureClassMethod, 'setName')
+            && $this->hasPermittedAttributeMethodCall($configureClassMethod)
+        ) {
+            return null;
+        }
+
         $hasChanged = false;
         foreach (self::METHODS_TO_ATTRIBUTE_NAMES as $methodName => $attributeName) {
             $resolvedExpr = $this->findAndRemoveMethodExpr($configureClassMethod, $methodName);
@@ -293,6 +304,40 @@ private function findAndRemoveMethodExpr(ClassMethod $classMethod, string $metho
         return $expr;
     }
 
+    private function hasPermittedAttributeMethodCall(ClassMethod $classMethod): bool
+    {
+        foreach (array_keys(self::METHODS_TO_ATTRIBUTE_NAMES) as $methodName) {
+            if ($this->hasPermittedMethodCall($classMethod, $methodName)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    private function hasPermittedMethodCall(ClassMethod $classMethod, string $methodName): bool
+    {
+        $hasMethodCall = false;
+
+        $this->traverseNodesWithCallable((array) $classMethod->stmts, function (Node $node) use (
+            &$hasMethodCall,
+            $methodName
+        ): null {
+            if (! $node instanceof MethodCall || ! $this->isName($node->name, $methodName)) {
+                return null;
+            }
+
+            $args = $node->getArgs();
+            if ($args !== [] && $this->isPermittedAttributeValue($args[0]->value)) {
+                $hasMethodCall = true;
+            }
+
+            return null;
+        });
+
+        return $hasMethodCall;
+    }
+
     private function isPermittedAttributeValue(Expr $expr): bool
     {
         if ($expr instanceof Scalar) {