Repository navigation
Drop default priority 0 in EventSubscriberToAttributeRector - #1100
Merged
Merged
Conversation
TomasVotruba
deleted the
strip-default-priority-zero-as-event-listener
branch
October 29, 2026 06:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
getSubscribedEvents()registers a listener with an explicit priority of0, the generated#[AsEventListener]attribute now omits thepriorityargument.0is the Symfony default, so emittingpriority: 0adds noise without changing behavior.Also confirmed: when no priority is present in the original, no
priorityargument is added - that was already the case.Added fixture
drop_default_priority.php.inc.