Skip to content

[CodeQuality] Skip abstract class on CompleteDynamicPropertiesRector#8182

Merged
TomasVotruba merged 1 commit into
mainfrom
skip-abstract-complete-dynamic-properties
Jul 13, 2026
Merged

[CodeQuality] Skip abstract class on CompleteDynamicPropertiesRector#8182
TomasVotruba merged 1 commit into
mainfrom
skip-abstract-complete-dynamic-properties

Conversation

@TomasVotruba

@TomasVotruba TomasVotruba commented Jul 13, 2026

Copy link
Copy Markdown
Member

Abstract class dynamic property might be accessed from a child class, so we cannot safely complete it. Skip abstract classes.

 abstract class SomeClass
 {
     public function set()
     {
         $this->value = 5;
     }
 }

Before: rule added public $value; to the abstract class. Now it is skipped, since a child class may declare/use that property.

@TomasVotruba TomasVotruba enabled auto-merge (squash) July 13, 2026 08:58
@TomasVotruba TomasVotruba merged commit 3c481b6 into main Jul 13, 2026
65 checks passed
@TomasVotruba TomasVotruba deleted the skip-abstract-complete-dynamic-properties branch July 13, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant