feat: Add AddNameToNullArgumentRector

[calebdw]

Hello!

This is similar to #7944 but for null arguments. I refactored the core logic into a reusable service so that other rules can be easily added in the future

Thanks!

[TomasVotruba]

Looks good, thank you

[u01jmg3]

Nice addition - is there a way of removing unnecessary parameters (because it's the default value) once a named argument has been introduced?

e.g.

This Rector made this change:

-$table->addRow(null, $styles['cant-split']);
+$table->addRow(height: null, style: $styles['cant-split']);

But we can go further:

-$table->addRow(height: null, style: $styles['cant-split']);
+$table->addRow(style: $styles['cant-split']);

---

(Ref: https://github.com/PHPOffice/PHPWord/blob/master/src/PhpWord/Element/Table.php#L67)

[samsonasik]

@u01jmg3 there is RemoveNullArgOnNullDefaultParamRector rule for that, activate deadCode set will combine 2 rules: SortCallLikeNamedArgsRector + RemoveNullArgOnNullDefaultParamRector see

https://getrector.com/demo/8186634c-2eb5-411d-8709-0f9d508924ab

You can configure:

<?php

use Rector\Config\RectorConfig;

return RectorConfig::configure()
    ->withPreparedSets(codeQuality: true, deadCode: true);

[u01jmg3]

It looks like Rector (or PHPStan) is not able to infer this from PHPWord...

[TomasVotruba]

@u01jmg3 Looks doable.
Can you create a new issue and provide 2 examples with both code and class as well?