Tighten Makefile parsing and follow Gradle's two-pass wrapper upgrade#93
Open
pambrose wants to merge 5 commits into
Open
Tighten Makefile parsing and follow Gradle's two-pass wrapper upgrade#93pambrose wants to merge 5 commits into
pambrose wants to merge 5 commits into
Conversation
Switch VERSION and GRADLE_VERSION extraction to sed for simpler parsing, tighten the help target formatting, and invoke ./gradlew wrapper twice in upgrade-wrapper per Gradle's documented two-pass upgrade procedure. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Renames the `gradle` key in libs.versions.toml to `gradle-wrapper` and updates the Makefile sed pattern that derives GRADLE_VERSION from it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VERSION/GRADLE_VERSIONextraction to singlesedexpressions instead ofgrep | cutandgrep | sedhelptarget output (newUsage:header, looser identifier regex, inlined$(MAKEFILE_LIST))./gradlew wrappertwice inupgrade-wrapperper Gradle's documented two-pass procedure, with a comment explaining whyTest plan
make helprenders the expected target listmake versioncheckreports the correctVERSIONandGRADLE_VERSIONmake upgrade-wrapperregeneratesgradle-wrapper.jarfor the catalog version🤖 Generated with Claude Code