Skip to content

[Android] Ellipsize single-line TextInput placeholders #57909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kosmydel wants to merge 2 commits into from
+29 −0
Closed

[Android] Ellipsize single-line TextInput placeholders #57909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80421a3
[Android] Ellipsize single-line TextInput placeholders
kosmydel Aug 12, 2026
b0da296
deslop
kosmydel Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...act-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,8 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
}
wasMultiline = isMultiline

updatePlaceholderEllipsize()

// We override the KeyListener so that all keys on the soft input keyboard as well as hardware
// keyboards work. Some KeyListeners like DigitsKeyListener will display the keyboard but not
// accept all input from it
Expand All @@ -606,6 +608,16 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
this.placeholder = placeholder
hint = placeholder
}
updatePlaceholderEllipsize()
}

private fun updatePlaceholderEllipsize() {
ellipsize =
if (!isMultiline) {
TextUtils.TruncateAt.END
} else {
null
}
}

public fun setFontFamily(fontFamily: String?) {
Expand Down
17 changes: 17 additions & 0 deletions ...actAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import android.text.InputType
import android.text.Layout
import android.text.SpannableString
import android.text.Spanned
import android.text.TextUtils
import android.util.DisplayMetrics
import android.view.Gravity
import android.view.View
Expand Down Expand Up @@ -196,9 +197,25 @@ class ReactTextInputPropertyTest {

manager.updateProperties(view, buildStyles("placeholder", "sometext"))
assertThat(view.hint).isEqualTo("sometext")
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)

manager.updateProperties(view, buildStyles("placeholder", null))
assertThat(view.hint).isNull()
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)
}

@Test
fun testPlaceholderEllipsizeRespectsMultiline() {
manager.updateProperties(view, buildStyles("placeholder", "a very long placeholder string"))
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)

manager.updateProperties(view, buildStyles("multiline", true))
view.commitStagedInputType()
assertThat(view.ellipsize).isNull()

manager.updateProperties(view, buildStyles("multiline", false))
view.commitStagedInputType()
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)
}

@Test
Expand Down
Loading