Let third-party pods resolve the C++ stable API guard headers - #57846
Open
coado wants to merge 1 commit into
Open
Let third-party pods resolve the C++ stable API guard headers#57846coado wants to merge 1 commit into
coado wants to merge 1 commit into
Conversation
Summary: `install_modules_dependencies` is the helper every third-party New Architecture library calls from its own podspec, and `update_search_paths` covers the user project and the pod targets that don't go through it. Neither knew about `React-cxxstableapi`. React Native's public C++ headers are starting to include the shared guard header `<react/cxxstableapi/UmbrellaGuard.h>`. The include is unconditional, so a third-party pod that includes any guarded React Native header has to be able to resolve it. Today it can't: in the default static-library mode `$(PODS_ROOT)/Headers/Public/React-cxxstableapi` is missing from the search path, and under `use_frameworks!` the `React_cxxstableapi.framework/Headers` entry is missing. Declare the dependency and add the matching framework header search path in both places. Changelog: [iOS][Added] - Add a `React-cxxstableapi` dependency to third-party New Architecture pods so they can resolve React Native's C++ API guard headers Differential Revision: D110052811
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110052811. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
install_modules_dependenciesis the helper every third-party New Architecture library calls from its own podspec, andupdate_search_pathscovers the user project and the pod targets that don't go through it. Neither knew aboutReact-cxxstableapi.React Native's public C++ headers are starting to include the shared guard header
<react/cxxstableapi/UmbrellaGuard.h>. The include is unconditional, so a third-party pod that includes any guarded React Native header has to be able to resolve it. Today it can't: in the default static-library mode$(PODS_ROOT)/Headers/Public/React-cxxstableapiis missing from the search path, and underuse_frameworks!theReact_cxxstableapi.framework/Headersentry is missing.Declare the dependency and add the matching framework header search path in both places.
Changelog:
[iOS][Added] - Add a
React-cxxstableapidependency to third-party New Architecture pods so they can resolve React Native's C++ API guard headersDifferential Revision: D110052811