xplat/js/react-native-github/packages/react-native/Libraries/Image/RCTImageStoreManager.mm (#57842) - #57842
Closed
meta-codesync[bot] wants to merge 1 commit into
Closed
xplat/js/react-native-github/packages/react-native/Libraries/Image/RCTImageStoreManager.mm (#57842)#57842meta-codesync[bot] wants to merge 1 commit into
meta-codesync[bot] wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
approved these changes
Aug 6, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
meta-codesync Bot
pushed a commit
that referenced
this pull request
Aug 8, 2026
…TImageStoreManager.mm (#57842) Summary: ...build_codegen_spec to generate the NativeImageStoreIOSSpec protocol and confirmed the module is a TurboModule. 2. Located and quoted the generated protocol signatures (all args NSString */RCTResponseSenderBlock). 3. Ran apply_cast_mod, which converted all four RCT_EXPORT_METHOD methods to plain ObjC declarations with zero FLAG lines (no type mismatches, so no RCTConvert reconciliation required). 4. Left RCT_EXPORT_MODULE() untouched. 5. Ran buck_build_verify (BUILD SUCCEEDED) and Lint (no lints found). _____ * Do **NOT** post in the CodemodService Feedback group about this specific diff. * If you have feedback, comment on the diff and use an appropriate diff action. This [diff was created](https://www.internalfb.com/intern/sandcastle/job/31525200232184606/) with [CodemodService](https://www.internalfb.com/codemod_service/CodemodConfigDevmateDropRctExportMethod). Reviewed By: cortinico, christophpurrer Differential Revision: D115003202
meta-codesync
Bot
force-pushed
the
export-D115003202
branch
from
August 8, 2026 22:55
197f68d to
28c77c6
Compare
…TImageStoreManager.mm (#57842) Summary: ...build_codegen_spec to generate the NativeImageStoreIOSSpec protocol and confirmed the module is a TurboModule. 2. Located and quoted the generated protocol signatures (all args NSString */RCTResponseSenderBlock). 3. Ran apply_cast_mod, which converted all four RCT_EXPORT_METHOD methods to plain ObjC declarations with zero FLAG lines (no type mismatches, so no RCTConvert reconciliation required). 4. Left RCT_EXPORT_MODULE() untouched. 5. Ran buck_build_verify (BUILD SUCCEEDED) and Lint (no lints found). _____ * Do **NOT** post in the CodemodService Feedback group about this specific diff. * If you have feedback, comment on the diff and use an appropriate diff action. This [diff was created](https://www.internalfb.com/intern/sandcastle/job/31525200232184606/) with [CodemodService](https://www.internalfb.com/codemod_service/CodemodConfigDevmateDropRctExportMethod). Reviewed By: cortinico, christophpurrer Differential Revision: D115003202
meta-codesync
Bot
force-pushed
the
export-D115003202
branch
from
August 8, 2026 22:57
28c77c6 to
6682096
Compare
Author
|
This pull request has been merged in 6d34b7a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
...build_codegen_spec to generate the NativeImageStoreIOSSpec protocol and confirmed the module is a TurboModule.
2. Located and quoted the generated protocol signatures (all args NSString */RCTResponseSenderBlock).
3. Ran apply_cast_mod, which converted all four RCT_EXPORT_METHOD methods to plain ObjC declarations with zero FLAG lines (no type mismatches, so no RCTConvert reconciliation required).
4. Left RCT_EXPORT_MODULE() untouched.
5. Ran buck_build_verify (BUILD SUCCEEDED) and Lint (no lints found).
This diff was created with CodemodService.
Reviewed By: cortinico, christophpurrer
Differential Revision: D115003202