Skip to content

fix(android): show soft keyboard on text selection #57477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikhilpakhloo wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(android): show soft keyboard on text selection #57477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb81d1e
fix(android): show soft keyboard on text selection
nikhilpakhloo Jul 8, 2026
321dfba
chore: format fantom docs
nikhilpakhloo Jul 8, 2026
16df7ca
Test: Fix compilation errors in Android TextInput soft keyboard test
nikhilpakhloo Jul 14, 2026
8223bec
Merge branch 'main' into fix/android-textinput-long-press-soft-keyboard
nikhilpakhloo Jul 14, 2026
446b5a5
Update print statement from 'Hello' to 'Goodbye'
nikhilpakhloo Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...act-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
private var keyListener: InternalKeyListener? = null
private var detectScrollMovement = false
private var onKeyPress = false
private var selectionWasCollapsed = true
private val textAttributes: TextAttributes
private var typefaceDirty = false
private var fontFamily: String? = null
Expand Down Expand Up @@ -492,13 +493,29 @@ public open class ReactEditText public constructor(context: Context) : AppCompat
if (selectionWatcher != null && hasFocus()) {
selectionWatcher?.onSelectionChanged(selStart, selEnd)
}
maybeShowSoftKeyboardForSelection(selStart, selEnd)
}

override fun onFocusChanged(focused: Boolean, direction: Int, previouslyFocusedRect: Rect?) {
super.onFocusChanged(focused, direction, previouslyFocusedRect)
if (focused && selectionWatcher != null) {
selectionWatcher?.onSelectionChanged(selectionStart, selectionEnd)
}
if (focused) {
maybeShowSoftKeyboardForSelection(selectionStart, selectionEnd)
}
}

private fun maybeShowSoftKeyboardForSelection(selectionStart: Int, selectionEnd: Int) {
if (!hasFocus() || !showSoftInputOnFocus) {
return
}

val selectionIsCollapsed = selectionStart == selectionEnd
if (!selectionIsCollapsed && selectionWasCollapsed) {
showSoftKeyboard()
}
selectionWasCollapsed = selectionIsCollapsed
}

internal fun setSelectionWatcher(selectionWatcher: SelectionWatcher?) {
Expand Down
Loading
Loading