RDKEMW-21962 : ctrlm-main - Use of potentially dangerous function

[dwolaver]

No description provided.

[Copilot]

Pull request overview

This PR addresses RDKEMW-21962 in the ctrlm-main (Control Manager) plugin by replacing use of localtime() (non-thread-safe / potentially dangerous) with localtime_r() in telemetry/logging code paths.

Changes:

• Updated RF4CE controller telemetry logging to use localtime_r() when formatting bind/unbind timestamps.
• Updated database dump logging to use localtime_r() when formatting stored binding timestamps.
• Updated controller status printing utilities to use localtime_r() when formatting various controller timestamps.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
src/rf4ce/ctrlm_rf4ce_controller.cpp	Switches bind/unbind telemetry timestamp formatting from localtime() to localtime_r().
src/database/ctrlm_database.cpp	Uses localtime_r() for printing stored binding time during DB dump.
src/ctrlm_utils.cpp	Uses localtime_r() for formatting controller status timestamps (binding/last key/battery update).

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

src/rf4ce/ctrlm_rf4ce_network.cpp:2258

• new_type is allocated with new but the error cleanup loop frees existing entries with g_free, which is a mismatched deallocator (undefined behavior). Use delete for these entries to match the allocation and the normal cleanup path later in the function.

         controller_type_details_t *new_type = new(std::nothrow) controller_type_details_t();
         if(new_type==NULL){
            XLOGD_ERROR("error on allocating.. aborting" );
            // if we could not malloc memory then we need to free our current mallocs and get out
            for (type_it = controller_types.begin(); type_it != controller_types.end(); type_it++) {

src/factory/ctrlmf_audio_capture.cpp:55

• This file now uses std::nothrow, which is declared in <new>. Add an explicit #include <new> to avoid relying on transitive includes (which can break builds depending on toolchain/standard library).

bool ctrlmf_audio_capture_init(uint32_t audio_frame_size, bool *has_local_mic_tap) {

   g_audio_cap.obj_ctrlm = new(std::nothrow) Iarm::ControlManager::ctrlm_iarm_client_control_manager_t;

   if(g_audio_cap.obj_ctrlm == NULL) {
      XLOGD_ERROR("out of memory");
      return(false);

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/rf4ce/ctrlm_rf4ce_network.cpp:2258

• In the allocation-failure cleanup path, controller_type_details_t* values are freed with g_free, but they are allocated with new and later freed with delete (see the normal cleanup loop at the end of the function). Using g_free here is a mismatched deallocator and is undefined behavior. Use delete for these entries as well.

         controller_type_details_t *new_type = new(std::nothrow) controller_type_details_t();
         if(new_type==NULL){
            XLOGD_ERROR("error on allocating.. aborting" );
            // if we could not malloc memory then we need to free our current mallocs and get out
            for (type_it = controller_types.begin(); type_it != controller_types.end(); type_it++) {

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/rf4ce/ctrlm_rf4ce_network.cpp:2262

• In the OOM cleanup path, type_it->second is freed with g_free, but these entries are allocated with new (and later released with delete at the end of the function). Mixing new/delete with malloc/free (via g_free) is undefined behavior; use delete here as well.

            // if we could not malloc memory then we need to free our current mallocs and get out
            for (type_it = controller_types.begin(); type_it != controller_types.end(); type_it++) {
               g_free(type_it->second);
               type_it->second = NULL;
            }

[egalla204]

approved for test

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.