RDKB-66764, RDKB-66765, RDKB-66766 - Wi-Fi Experience Index feature. - #1443
Merged
Merged
Conversation
Reason for change: Added Device.X_RDKCENTRAL-COM_WEI.Diagnostic.Enable to configure WEI_DIAGNOSTIC_COUNTERS bundle Test Procedure: Connect multiple clients and verify the WEI_DIAGNOSTIC_COUNTERS bundle Risks: low Signed-off-by: Raghava_Nayani@comcast.com
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add an upgrade path that initializes the new field for existing rows without overriding explicit user settings.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds configurable, persistent support for Device.X_RDKCENTRAL-COM_WEI.Diagnostic.Enable.
Changes:
- Adds WEI diagnostic configuration and default mapping.
- Exposes RBUS GET/SET handling.
- Updates generated definitions and OVSDB schema.
Existing configuration rows may retain diagnostics disabled after upgrade because the new field is not migrated to its intended default.
File summaries
| File | Summary |
|---|---|
source/db/wifi_db_apis.c |
Maps and persists diagnostic configuration. |
source/core/wifi_ctrl_wei_rfc.h |
Defines the RBUS parameter and configuration field. |
source/core/wifi_ctrl_rbus_handlers.c |
Registers RBUS GET/SET handling. |
lib/inc/schema_gen.h |
Adds generated schema declarations. |
config/rdkb-wifi.ovsschema |
Adds the persistent OVSDB column. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rshah-1
approved these changes
Sep 18, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
🔨 Build summaryCommit Banana Pi R4 - MLO — build success
|
Contributor
🔎 clang-tidy (advisory)🔎 clang-tidy advisory — 1 findings |
rshah-1
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-66764, RDKB-66765, RDKB-66766 - Wi-Fi Experience Index feature.
Reason for change: Added Device.X_RDKCENTRAL-COM_WEI.Diagnostic.Enable to configure WEI_DIAGNOSTIC_COUNTERS bundle
Test Procedure: Connect multiple clients and verify the WEI_DIAGNOSTIC_COUNTERS bundle
Risks: low
Signed-off-by: Raghava_Nayani@comcast.com