XB-2787: Fix radio bitmap calculation - #1297
Draft
bmilcz-comcast wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts MLO (MLD) update logic so the returned radio_bitmap only flags radios where mld_enable and/or mld_link_id actually changed, preventing unnecessary reconfiguration work that was causing a recurring ~25s delay on subsequent boots.
Changes:
- Update
update_mld_groups()to cache originalmld_enablestate per VAP and only setradio_bitmapwhen the final enable state differs from the baseline (and whenmld_link_idis overridden). - Centralize
MAX_VAP_INDEXinwifi_ctrl.h(removing the local define fromwifi_ctrl_queue_handlers.c). - Minor comment/docstring and formatting adjustments around MLD handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/core/wifi_ctrl.h | Introduces MAX_VAP_INDEX used for VAP indexing/bounds in core code. |
| source/core/wifi_ctrl.c | Refines update_mld_groups() radio bitmap calculation using baseline mld_enable caching and conditional bitmap updates. |
| source/core/wifi_ctrl_queue_handlers.c | Removes local MAX_VAP_INDEX define to rely on the shared header definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Due to always being set for all radios on all boots, it was causing constant 25s delay. Test Procedure: Verify if the delay is present on subsequent boots without any changes to specific VAPs Risks: None Priority: P2 Signed-off-by: Brayan Milczarek <brayan_milczarek@comcast.com>
bmilcz-comcast
force-pushed
the
xb10-2878
branch
from
July 27, 2026 15:34
5a0749c to
998a147
Compare
bmilcz-comcast
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Due to always being set for all radios on all boots, it was causing constant 25s delay.
Test Procedure: Verify if the delay is present on subsequent boots without any changes to specific VAPs
Risks: None
Priority: P2