Skip to content

RDKCOM-5592:RDKBACCL-1608: [TDK][AUTO][BPI][DML]Device.WiFi.NeighboringWiFiDiagno… - #1291

Open
tinaelizabeth84 wants to merge 1 commit into
rdkcentral:mainfrom
tinaelizabeth84:RDKCOM-5592
Open

RDKCOM-5592:RDKBACCL-1608: [TDK][AUTO][BPI][DML]Device.WiFi.NeighboringWiFiDiagno…#1291
tinaelizabeth84 wants to merge 1 commit into
rdkcentral:mainfrom
tinaelizabeth84:RDKCOM-5592

Conversation

@tinaelizabeth84

Copy link
Copy Markdown

…stic.DiagnosticsState is empty (#1118)

Reason for Change: Set default value of DiagnosticsState to "None" instead of leaving it empty.
Test Procedure: Verify that DiagnosticsState is "None" by default when not explicitly set and it's functionality should work.
Risks: Low.

Copilot AI review requested due to automatic review settings July 23, 2026 20:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an issue where the TR-181 parameter Device.WiFi.NeighboringWiFiDiagnostic.DiagnosticsState could be returned as an empty string by initializing it to "None" during WiFi monitor startup.

Changes:

  • Initialize g_monitor_module.neighbor_scan_cfg.DiagnosticsState to "None" in init_wifi_monitor() so it is never empty by default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…stic.DiagnosticsState is empty (rdkcentral#1118)

Reason for Change: Set default value of DiagnosticsState to "None" instead of leaving it empty.
Test Procedure: Verify that DiagnosticsState is "None" by default when not explicitly set and it's functionality should work.
Risks: Low.

Signed-off-by: ksaipr036 <kosika_saipriya@comcast.com>
Co-authored-by: Narendra Varma Dandu <narendandu@gmail.com>
Copilot AI review requested due to automatic review settings July 24, 2026 13:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@tinaelizabeth84 tinaelizabeth84 changed the title RDKBACCL-1608: [TDK][AUTO][BPI][DML]Device.WiFi.NeighboringWiFiDiagno… RDKCOM-5592:RDKBACCL-1608: [TDK][AUTO][BPI][DML]Device.WiFi.NeighboringWiFiDiagno… Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants