RDKB-65853: Fixing Vulnerability issue#1284
Open
sshah500 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses vulnerability findings in the WiFi RBUS handlers by moving large webconfig_subdoc_data_t usage from stack to heap and ensuring proper cleanup of encoded webconfig payloads.
Changes:
- Updated
apply_ignite_config()to allocatewebconfig_subdoc_data_ton the heap and free it on all paths. - Adjusted ignite webconfig event payload length to include the terminating NUL (
strlen + 1) when pushing to the controller queue. - Fixed a leak in
set_force_vap_apply()by freeing encoded webconfig data on the success path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
4233
to
4235
| push_event_to_ctrl_queue((const cJSON *)data->u.encoded.raw, | ||
| (strlen(data->u.encoded.raw) + 1), wifi_event_type_webconfig, | ||
| wifi_event_webconfig_set_data_force_apply, NULL); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing Vulnerability issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: sachinkumar_shah@comcast.com