Skip to content

RDKEMW-19866: Merge develop to main - #472

Merged
B-Larsen merged 4 commits into
mainfrom
develop
Sep 11, 2026
Merged

B-Larsen merged 4 commits into
mainfrom
develop

Conversation

@B-Larsen

Copy link
Copy Markdown
Contributor

Description

What does this PR change/fix and why?

If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.

Test Procedure

How to test this PR (if applicable)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

sajilal711 and others added 4 commits August 24, 2026 11:21
* RDKEMW-17166: make container memory limits zram-aware

* RDKEMW-17166: Fix L2 test

* RDKEMW-17166: only apply zram-aware mem limit when swapLimit is explicit

* Update DobbySpecConfig.cpp

* RDKEMW-17166: Fix copilot reviews

* RDKEMW-17166: Fix copilot reviews
RDKEMW-19866: Update Dobby v3.22.0
Copilot AI lite review requested due to automatic review settings September 11, 2026 01:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved review findings remain in error reporting, test coverage, and specification synchronization.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates Dobby to 3.22.0 with zram-aware memory-limit handling for legacy container specifications.

Changes:

  • Adds zram-based memory and swap calculations.
  • Updates related tests and bundle normalization.
  • Refreshes documentation, guidance, and version metadata.
File summaries
File Description
tests/L2_testing/test_runner/bundle_generation.py Normalizes host-dependent memory output.
tests/L1_testing/tests/DobbySpecConfigTest/DobbySpecConfigTest.cpp Updates memory and swap-limit tests.
README.md Documents zram-aware memory behavior.
CMakeLists.txt Bumps the project version to 3.22.0.
bundle/lib/source/DobbySpecConfig.cpp Implements zram detection and memory-limit scaling.
bundle/lib/include/DobbySpecConfig.h Declares scaling helpers and state.
.github/instructions/General.instructions.md Adds repository coding guidance.
.github/copilot-instructions.md References repository review guidance.
Review details

Suppressed comments (1)

tests/L2_testing/test_runner/bundle_generation.py:85

  • Comparing swap with the generated limit cannot tell whether zram scaling occurred. For the existing swap_limit spec (swap=5996544, limit=2998272) on a host with no zram, this condition is still true, so the normalizer deletes limit from both configs and the test stops checking the requested memory limit. Conversely, an original config where swap == limit can mismatch when only the generated config is zram-scaled. Pass the explicit scaling/expected value into normalization (or otherwise compare a host-independent expected limit) instead of using this heuristic.
            if swap is not None and swap != -1 and swap != limit:
                memory.pop("limit", None)
  • Files reviewed: 8/8 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread bundle/lib/source/DobbySpecConfig.cpp
Comment thread tests/L1_testing/tests/DobbySpecConfigTest/DobbySpecConfigTest.cpp
Comment thread bundle/lib/source/DobbySpecConfig.cpp
@B-Larsen
B-Larsen merged commit 11d7907 into main Sep 11, 2026
45 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants