Conversation
* RDKEMW-17166: make container memory limits zram-aware * RDKEMW-17166: Fix L2 test * RDKEMW-17166: only apply zram-aware mem limit when swapLimit is explicit * Update DobbySpecConfig.cpp * RDKEMW-17166: Fix copilot reviews * RDKEMW-17166: Fix copilot reviews
RDKEMW-19866: Update Dobby v3.22.0
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved review findings remain in error reporting, test coverage, and specification synchronization.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Dobby to 3.22.0 with zram-aware memory-limit handling for legacy container specifications.
Changes:
- Adds zram-based memory and swap calculations.
- Updates related tests and bundle normalization.
- Refreshes documentation, guidance, and version metadata.
File summaries
| File | Description |
|---|---|
tests/L2_testing/test_runner/bundle_generation.py |
Normalizes host-dependent memory output. |
tests/L1_testing/tests/DobbySpecConfigTest/DobbySpecConfigTest.cpp |
Updates memory and swap-limit tests. |
README.md |
Documents zram-aware memory behavior. |
CMakeLists.txt |
Bumps the project version to 3.22.0. |
bundle/lib/source/DobbySpecConfig.cpp |
Implements zram detection and memory-limit scaling. |
bundle/lib/include/DobbySpecConfig.h |
Declares scaling helpers and state. |
.github/instructions/General.instructions.md |
Adds repository coding guidance. |
.github/copilot-instructions.md |
References repository review guidance. |
Review details
Suppressed comments (1)
tests/L2_testing/test_runner/bundle_generation.py:85
- Comparing
swapwith the generatedlimitcannot tell whether zram scaling occurred. For the existingswap_limitspec (swap=5996544,limit=2998272) on a host with no zram, this condition is still true, so the normalizer deleteslimitfrom both configs and the test stops checking the requested memory limit. Conversely, an original config whereswap == limitcan mismatch when only the generated config is zram-scaled. Pass the explicit scaling/expected value into normalization (or otherwise compare a host-independent expected limit) instead of using this heuristic.
if swap is not None and swap != -1 and swap != limit:
memory.pop("limit", None)
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
madanagopalt
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR change/fix and why?
If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.
Test Procedure
How to test this PR (if applicable)
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)