Skip to content

refactor(frontier): remove AddOrganizationUsers RPC#479

Merged
whoAbhishekSah merged 1 commit intomainfrom
feat/remove-add-org-users-rpc
Apr 21, 2026
Merged

refactor(frontier): remove AddOrganizationUsers RPC#479
whoAbhishekSah merged 1 commit intomainfrom
feat/remove-add-org-users-rpc

Conversation

@whoAbhishekSah
Copy link
Copy Markdown
Member

Summary

Context

AddOrganizationUsers added members with a hardcoded viewer role and no way to specify the desired role. The replacement AddOrganizationMembers (on AdminService) accepts a role per member and is gated behind superadmin auth.

Test plan

  • buf lint passes
  • buf breaking passes (WIRE category allows RPC removal)

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7954b41d-c8e7-44ab-87db-2e3b8a99fbae

📥 Commits

Reviewing files that changed from the base of the PR and between 432d98c and 2adbc20.

📒 Files selected for processing (1)
  • raystack/frontier/v1beta1/frontier.proto

📝 Walkthrough

Walkthrough

This pull request removes the AddOrganizationUsers RPC endpoint from the FrontierService in the protobuf definition file. The removal includes the service method declaration and the associated AddOrganizationUsersRequest and AddOrganizationUsersResponse message types. This eliminates the defined API surface for this specific operation, reducing the available endpoints in the Frontier service API.

Suggested reviewers

  • rohilsurana
  • rsbh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

The latest Buf updates on your PR. Results from workflow Validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 21, 2026, 7:04 AM

This RPC has been superseded by AddOrganizationMembers on the AdminService,
which supports explicit role assignment per member. The server-side handler
was already removed in raystack/frontier#1548.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@whoAbhishekSah whoAbhishekSah force-pushed the feat/remove-add-org-users-rpc branch from 6558217 to 2adbc20 Compare April 21, 2026 07:03
@whoAbhishekSah whoAbhishekSah merged commit 0a6c0b4 into main Apr 21, 2026
2 checks passed
@whoAbhishekSah whoAbhishekSah deleted the feat/remove-add-org-users-rpc branch April 21, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants